Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice and red and blinky ui label for broken plugins #1280

Merged
merged 2 commits into from
Apr 13, 2016

Conversation

foot
Copy link
Contributor

@foot foot commented Apr 13, 2016

Fixes #1271

const error = status !== 'ok';
const className = classNames({ error });
const title = error ?
`Status: ${status}. (Plugin description: ${description})` :

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@davkal
Copy link
Contributor

davkal commented Apr 13, 2016

The blinking red is a bit subtle, and our first use of red to depict an error. The reconnect error that is displayed when the backend is not available, blinks with a circled exclamation mark. Why not just use that?

@foot
Copy link
Contributor Author

foot commented Apr 13, 2016

First thought is that is was very icon heavy down there so didn't actually
try it out. Will give it a spin.

On 13 April 2016 at 14:24, David notifications@github.com wrote:

The blinking red is a bit subtle, and our first use of red to depict an
error. The reconnect error that is displayed when the backend is not
available, blinks with a circled exclamation mark. Why not just use that?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1280 (comment)

@davkal
Copy link
Contributor

davkal commented Apr 13, 2016

There is a fa icon w/o the circle if that helps.

@foot foot merged commit 412fdd1 into master Apr 13, 2016
@foot foot deleted the 1271-broken-plugin-status branch April 13, 2016 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants